wp-media / wp-media/imagify-plugin

Optimize missing thumbnail sometimes isnot working for custom size

Open
#894 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

priority: medium severity: moderate type: bug
Dominant language
PHP
Stars
82
Forks
31
Avg merge
5d 10h
Merged PRs (30d)
9

Description

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version =>2.2.3
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
When a custom thumbnail is set using the following filter in the active theme, when clicking optimize 1 missing thumbnail is not working with some images

add_action( 'after_setup_theme', function() {
add_image_size( '200', 200, 200 );
} );

To Reproduce
Steps to reproduce the behavior:

  1. Use the filter above
  2. Upload an image like attached
  3. Click optimize 1 missing thumbnail link in the media library list for the optimized image
  4. Nothing happens and the link is still there
    360_F_289306269_rJ04x9o9Dbv8zHcImf9kRZA08bVCimIP
    tablet_11971515051363428

Expected behavior
The link 'optimize 1 missing thumbnail' gets hidden and optimize the needed thumbnail or show notice if something is wrong (please refer to @wp-media/product to confirm the expected)

Screenshots
Screenshot from 2024-08-14 17-01-26

Additional context

  • If this image is used instead, clicking optimize 1 thumbnail will be hidden once clicked and optimized images will be updated

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named; reproduce the issue with the custom add_image_size filter in a WordPress media library and compare the two supplied image cases. Done means the missing-thumbnail link is hidden after optimization and the needed thumbnail is generated, or a clear error notice is shown.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
backend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.