wp-media / wp-media/imagify-plugin

PHP Deprecated: Function _imagify_display_bulk_page() is deprecated since version 1.7 when open bulk optimization page at next-gen gallery

Open
#862 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3rd party compatibility priority: low severity: minor type: bug
Dominant language
PHP
Stars
82
Forks
31
Avg merge
5d 10h
Merged PRs (30d)
9

Description

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version =>2.1.3 & 2.2.1
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
Deprecated notice is added to debug.log when open bulk optimization page at next-gen gallery

To Reproduce
Steps to reproduce the behavior:

  1. Activate next-gen Gallery
  2. Activate imagify
  3. visit next-gen gallery bulk optimization i.e http://localhost:10090/wp-admin/admin.php?page=imagify-ngg-bulk-optimization
  4. check debug.log
    [19-Mar-2024 13:05:59 UTC] PHP Deprecated: Function _imagify_display_bulk_page() is deprecated since version 1.7! Use Imagify_Views::get_instance()->display_bulk_page() instead. in /home/mai/Local Sites/imagifynginx6/app/public/wp-includes/functions.php on line 6078
    Expected behavior
    A clear and concise description of what you expected to happen.
    No deprecated notice in debug.log

Additional context
Add any other context about the problem here.

  • PHP 8.1.23
  • WP 6.5-RC2-57846
  • Next-gen keeps loading sign in bulk page of next gen gallery even without click imagify all
    Screenshot from 2024-03-19 16-06-58

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from the WordPress admin entry point at admin.php?page=imagify-ngg-bulk-optimization with Next-gen Gallery and Imagify active, then inspect the call to _imagify_display_bulk_page(). Confirm the deprecated notice and the related bulk-page loading behavior are resolved, using the replacement named in the notice as the completion reference.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.