wp-media / wp-media/imagify-plugin

Optimize btn is displayed after click delete generated webp or next-gen in AVIF branch

Open
#812 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
82
Forks
31
Avg merge
5d 10h
Merged PRs (30d)
9

Description

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version =>2.1.3.1
  • Used the search feature to ensure that the bug hasn’t been reported before

Describe the bug
If we uploaded small image that is already optimized then delete webp version, optimize btn is displayed instead of just change delete link to generate link

To Reproduce
Steps to reproduce the behavior:

  1. WebP is enabled on trunk or on AVIF branch, the AVIF is off
  2. upload small image like the one attached
  3. check media library
  4. click delete webp image or delete Next-Gen link => optimize btn displayed

Expected behavior
When click delete webp or next-gen, switch the link to generate webp or next-gen (as we didn't delete optimized images)

Screenshots
If applicable, add screenshots to help explain your problem.
images (47)
Screenshot from 2024-02-23 11-09-23

Additional context
Add any other context about the problem here.

  • on trunk, delete webp isnot displayed for large image

Acceptance Criteria (for WP Media team use only)
Clear instructions for developers, to be added before the grooming

  • When click on delete link, generate link displayed after deletion
  • When click on generate link, delete link is displayed after generation
  • This applies to big/small image
  • link displayed in media library and image edit

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior in the WordPress media library and image edit views with WebP enabled and AVIF disabled, using a small already-optimized image. Check the delete and generate link states for both small and large images. Done means deletion shows the generate link and generation shows the delete link in both views.

Written by the indexing model from the issue text.

Assessment

Tech stack
php, wordpress
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.