wp-media / wp-media/imagify-plugin

Fix WebP picture method for images served via JS script

Open
#522 1 comment 0 reactions 1 assignee View on GitHub

@iCaspar is already working on this.

Since Oct 15, 2020.

needs: grooming priority: medium severity: minor type: bug
Dominant language
PHP
Stars
82
Forks
31
Avg merge
5d 10h
Merged PRs (30d)
9

Description

When images are served via JS, there is a problem as we use \n in plugin to render them.

Example:

data.push({
position: new google.maps.LatLng(xxxxx,yyyyy),
content: '<?php the_post_thumbnail('thumbnail'); ?>'
});

The problem comes from Display.php

More context can be found in this thread of wp.org forum.

This should be the easy fix (simply removing \n from the code, but would make the code output look ugly.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.