worldfnd / worldfnd/provekit

`provekit/backend/bn254/src/frontend/witness_generator`: serializes the ABI as a json string. Something like CBOR might be better.

Open
#467 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

to do tracker
Dominant language
Noir
Stars
138
Forks
47
Avg merge
1d 34m
Merged PRs (30d)
6

Description

On 2026-07-06 in 05de18e “Merge pull request #458 from worldfnd/sl/goldilocks-field-abstraction”:

serializes the ABI as a json string. Something like CBOR might be better.

#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct NoirWitnessGenerator {
    // Note: Abi uses an [internally tagged] enum format in Serde, which is not compatible
    // with some schemaless formats like Postcard.
    // [internally-tagged]: https://serde.rs/enum-representations.html
    // TODO: serializes the ABI as a json string. Something like CBOR might be better.
    #[serde(with = "serde_jsonify")]
    pub abi: Abi,

    /// ACIR witness index to R1CS witness index
    /// Index zero is reserved for constant one, so we can use `NonZeroU32`

From provekit/backend/bn254/src/frontend/witness_generator.rs:15

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in provekit/backend/bn254/src/frontend/witness_generator.rs at the NoirWitnessGenerator abi field and read the serde_jsonify handling. Review the ABI's internally tagged enum constraint and the surrounding serialization setup before deciding whether an alternative format is suitable. Done means the ABI no longer relies on a JSON string and the chosen representation preserves the required serialization and deserialization behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.