Refactor: Introduce a type alias WitnessIdx

Open
#347 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Domain
compilers

Research direction

Start by reading the provekit compiler code and the discussion referenced in pull request #310. Identify where usize is used for witness indexes and determine the full scope of introducing the WitnessIdx alias. Done means the relevant witness-index parameters and uses consistently use the alias without changing behavior.

Written by the indexing model from the issue text.

Description

Right now in provekit compiler everything is usize and it is causing confusion in reading function params.

Comment ref : https://github.com/worldfnd/provekit/pull/310#discussion_r2951960092

Dominant language
Noir
Stars
138
Forks
47
Avg merge
1d 34m
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from worldfnd/provekit

All issues in worldfnd/provekit

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.