worldfnd / worldfnd/provekit

Refactor: remove unwraps() from compiler code

Open
#332 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

code quality refactor
Dominant language
Noir
Stars
138
Forks
47
Avg merge
1d 34m
Merged PRs (30d)
6

Description

Right now in provekit there are lot of unwraps() and on panic it is difficult to track the specific issue. Instead of that we introduce a proper error propagation logic.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name specific files or tests; start by locating the compiler code and inventorying its unwraps(). Define the error-propagation scope from those call sites, then verify that compiler failures report traceable errors without the targeted unwrap()-based panics.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.