worldfnd / worldfnd/provekit

`playground/cm31_ntt/benches/ntt_r8_hybrid_ps`: refactor

Open
#232 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

to do tracker
Dominant language
Noir
Stars
138
Forks
47
Avg merge
1d 34m
Merged PRs (30d)
6

Description

On 2025-11-05 in ac42e37 “Merge pull request #227 from worldfnd/sl/duplicate-witness”:

refactor


        let mut f = vec![CF::zero(); n];
        for i in 0..n {
            f[i] = rng.r#gen();
        }
        // TODO: refactor
        let precomp_small = if n < NTT_BLOCK_SIZE_FOR_CACHE {
            precomp_for_ntt_r8_ip_p(n, wn).unwrap()
        } else {
            precomp_for_ntt_r8_ip_p(
                NTT_BLOCK_SIZE_FOR_CACHE,

From playground/cm31_ntt/benches/ntt_r8_hybrid_ps.rs:22

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read playground/cm31_ntt/benches/ntt_r8_hybrid_ps.rs around line 22 and trace the surrounding precomputation calls first. Compare the benchmark’s structure with related NTT benchmarks, then run the relevant benchmark to establish its current behavior. Done means the TODO refactor is resolved in that file and the benchmark still runs.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cryptography, performance
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.