worldfnd / worldfnd/provekit

`provekit/common/src/sparse_matrix`: Make it default infinite size instead.

Open
#157 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

to do tracker
Dominant language
Noir
Stars
138
Forks
47
Avg merge
1d 34m
Merged PRs (30d)
6

Description

On 2025-08-29 in 2a57572 “Merge pull request #153 from worldfnd/px/refactor”:

Make it default infinite size instead.

    pub const fn num_entries(&self) -> usize {
        self.values.len()
    }

    pub fn grow(&mut self, rows: usize, cols: usize) {
        // TODO: Make it default infinite size instead.
        assert!(rows >= self.num_rows);
        assert!(cols >= self.num_cols);
        self.num_rows = rows;
        self.num_cols = cols;
        self.new_row_indices.resize(rows, self.values.len() as u32);

From provekit/common/src/sparse_matrix.rs:59

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with provekit/common/src/sparse_matrix.rs, especially grow, then inspect its callers to understand how matrix dimensions are initialized and enforced. Confirm the intended meaning of a default infinite size and identify affected coverage; done means the sparse matrix supports that behavior without breaking existing growth or dimension checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cryptography
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.