worldfnd / worldfnd/provekit

`skyscraper/fp-rounding/src/rounding_guard`: Force one per thread.

Open
#151 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

to do tracker
Dominant language
Noir
Stars
138
Forks
47
Avg merge
1d 34m
Merged PRs (30d)
6

Description

On 2025-08-27 in d91b2f2 “Merge pull request #142 from worldfnd/sl/skyscraper-refactor”:

Force one per thread.

///
/// # Safety
///
/// This type is marked !Send + !Sync because FPCR is a per-core / per OS-thread
/// register.
// TODO: Force one per thread.
pub struct RoundingGuard<M: RoundingDirectionMarker> {
    previous: RoundingDirection,
    mode:     PhantomData<M>,
    _marker:  NotSendSync,
}

From skyscraper/fp-rounding/src/rounding_guard.rs:20

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in skyscraper/fp-rounding/src/rounding_guard.rs at the TODO and read the surrounding RoundingGuard safety comments, especially the FPCR per-core or per-thread constraint. Determine how the guard should enforce one instance per thread and define completion as thread-local enforcement that preserves the documented safety guarantees.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cryptography
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.