workbenchdev / workbenchdev/Workbench
Lint Rust demos with clippy
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 844
- Forks
- 91
- Avg merge
- 7h 12m
- Merged PRs (30d)
- 1
Description
One thing that would be good to have is to check all Rust demos with clippy.
Clippy both ensures that they build correctly, but also acts as a linter.
Looking at the code it seems like we currently lint with language servers.
That is possible with rust-analyzer, but it's also wasteful compared to just running cargo clippy directly.
What I think should be done:
- Loop through each demo
- Copy all relevant Rust files into the demo
- Run cargo clippy (make sure that target dir is set correctly)
- Remove copied Rust files again
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/cli/main.js around line 114 and trace how demos are currently linted with language servers. Identify how demos and their relevant Rust files are collected, then verify that each demo runs cargo clippy with the correct target directory and cleans up copied files afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, rust
- Domain
- cli, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100