workbenchdev / workbenchdev/Workbench
DBusPreviewer does not wait for the previewer to register its D-Bus Object
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 844
- Forks
- 91
- Avg merge
- 7h 12m
- Merged PRs (30d)
- 1
Description
Right now the DBusPreviewer code in Workbench starts the Vala previewer in a seperate process and then waits for the connection to be established. The code then assumes the D-Bus object that the previewer registers then also exists.
An issue arises when the object is for some reason not registered fast enough. I'm running into this issue at the moment with the Python previewer, which is slower to register the object than the JS code is at trying to access the object.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the DBusPreviewer code in Workbench and tracing process startup through the D-Bus connection and object access. Reproduce the race with the slower Python previewer and compare it with the JavaScript path. Done means access waits until the previewer’s D-Bus object is registered, including for the Python previewer.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, python
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100