workbenchdev / workbenchdev/Workbench
Better report XML parsing errors
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 844
- Forks
- 91
- Avg merge
- 7h 12m
- Merged PRs (30d)
- 1
Description
XML UI is parsed and rendered on change.
The parsing errors are displayed in the console which is fine but not ideal.
Instead we could display the error directly in the source view at the right line / character.
(re.sonny.Workbench:4): Gjs-WARNING **: 18:24:56.881: JS ERROR: GLib.MarkupError: Error on line 8 char 6: “<” is not a valid character following the close element name “object”; the allowed character is “>”
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the XML UI parsing and source-view rendering entry points, then reproduce the malformed XML example to observe the current console error. Trace how the reported line and character are exposed by the parser. Done means the parsing error appears in the source view at the corresponding location instead of only in the console.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- desktop
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100