workbenchdev / workbenchdev/Workbench

Allow using actions in the external preview

Open
#110 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

vala
Dominant language
JavaScript
Stars
844
Forks
91
Avg merge
7h 12m
Merged PRs (30d)
1

Description

When using Vala, the code and preview runs in a separate process.

So far, we were unable to use actions there so we had to disable/downgrade demos for Vala. See

This ticket is about enabling the usage of actions in library entries when using Vala.

See the previous description below and comments for an analysis of the issue.

Since then, the architecture changed a little bit and the external process isn't a GApplication anymore. Instead Workench and the external process communicate via a direct dbus connection instead of via the session bus.

See https://github.com/sonnyp/Workbench/pull/184/files#diff-24cdf4b8c7c2fbd1c6b43e8b7bcc877d14cae496dd01e82eb212b6d5b4c68d59

Please note that Flatpak apps cannot have multiple dbus targets. https://github.com/flatpak/flatpak/issues/1902

Todo

  • Permit usage of GActions in Vala examples
  • Upgrade Vala examples to use GActions like the js ones
    • Toasts
    • Notifications

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the external-process architecture described in the linked Workbench pull request #184 and compare the Vala examples with their JavaScript counterparts. Trace how the direct D-Bus connection handles actions; done means Vala library entries can use GActions and the Toasts and Notifications examples are upgraded.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
desktop
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.