wordpress-mobile / wordpress-mobile/release-toolkit
Read `FASTLANE_SKIP_TOOLKIT_UPDATE_CHECK` in `check_for_toolkit_updates` action
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 31
- Forks
- 10
- Avg merge
- 5h 45m
- Merged PRs (30d)
- 2
Description
Currently, projects such as WordPress iOS use check_for_toolkit_updates in combination with the FASTLANE_SKIP_TOOLKIT_UPDATE_CHECK environment variable as a way to bypass the process. E.g.
check_for_toolkit_updates unless is_ci || ENV['FASTLANE_SKIP_TOOLKIT_UPDATE_CHECK']
Having the env var spelled out at the project level is convenient for discoverability, but I wonder if we would be better served "at scale" if the command itself read that env var, and possibly the is_ci value, too.
Doing so would streamline adopting the command ("action", really) to simply calling it.
We could compensate for discoverability by:
- Adding a message as part of the output informing users of the env var existence
- Adding a
forceparameter to bypass those internal checks
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the implementation of the check_for_toolkit_updates action and trace how it currently performs its checks. Review the existing FASTLANE_SKIP_TOOLKIT_UPDATE_CHECK and is_ci behavior, then decide how output messaging and a force parameter should interact with them. Done means the chosen behavior is documented in tests and the action can be called without project-level bypass logic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- release, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100