wordpress-mobile / wordpress-mobile/release-toolkit
Add RtL support for draw_text_attachment_to_canvas
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 31
- Forks
- 10
- Avg merge
- 5h 45m
- Merged PRs (30d)
- 2
Description
Description
Text alignment for screenshot overlay text must be flipped for RtL languages.
Background Context
Ref: https://github.com/wordpress-mobile/WordPress-iOS/pull/16707
While adding the ar-SA (Arabic) and he (Hebrew) locales to screenshot generation, I realized that the overlay text alignment needs to to be flipped for RtL languages.
In the Jetpack app, the splash image has text that's left-aligned for LtR languages, which needs to be flipped to be right-aligned for RtL languages.
JP
 |
 |
 |
 |
 |
 |
|---|
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for the draw_text_attachment_to_canvas entry point and inspect the screenshot-generation code around it. Check for existing tests covering overlay text alignment or locale handling. Done means overlay text is right-aligned for RTL languages such as Arabic and Hebrew while preserving the current left alignment for LTR languages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- internationalization, tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100