wordpress-mobile / wordpress-mobile/WordPress-iOS
Consider logging and error reporting for WordPressShared and UserAgent
@mokagio is already working on this.
Since Mar 19, 2025.
- Dominant language
- Swift
- Stars
- 3.9k
- Forks
- 1.2k
- Avg merge
- 23h 51m
- Merged PRs (30d)
- 58
Description
https://github.com/wordpress-mobile/WordPress-iOS/pull/24216 extracts WPUserAgent to WordPressShared to enable sharing it with other modules. Whether or not modules should access it is debatable, but that's the state of the code we have at the moment and it's convenient to play along in the interest of laying the foundation to quickly prototype the dedicated Reader app.
Part of the work included adding CocoaLumberjack as a dependency in WordPressShared, but this resulted in some of the tests crashing because of compilation issues.
Given the whole idea of having a logging library in WordPressShared was debatable, https://github.com/wordpress-mobile/WordPress-iOS/pull/24216#discussion_r1994867950, and because of the focus in establishing support for Reader, I decided to simply remove the dependency via f95be44483 instead of figuring out where the issue was.
This is a bread crumb to remind us to go back and find out.
See also #24165
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.