Cannot form weak reference to instance of class PUPickerRemoteViewController

Cannot form weak reference to instance (0x109349a00) of class PUPickerRemoteViewController. It is possible that this object was over-released, or is in the process of deallocation. > objc[2323]: Cannot form weak reference to instance (0x109349a00) of class PUPickerRemoteViewController. It is possible that this object was over-released, or is in the process of deallocation.

Sentry

The crash is grouped with other SIGABRT crashes on Jetpack and WordPress. However, the current spike is mostly related to PUPickerRemoteViewController:

• Jetpack iOS events for 24.0
• WordPress iOS events for 24.0

Observations

• iPad only
• PHPickerViewController (and consequentially PUPickerRemoteViewController) doesn’t get deallocated, since it’s held strongly by AztecPostViewController (https://github.com/wordpress-mobile/WordPress-iOS/blob/9ee96a5a70988ff877793c6c30dc701b9285433b/WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift#L426). We could make it weak and keep it same behavior.
• AztecPostViewController contains code, with a comment We need to auto-close the input media picker when multitasking panes are resized:

if UIDevice.isPad() {
   closeMediaPickerInputViewController()
}

Steps to reproduce the behavior

Tested on [device], iOS [version], Jetpack iOS / WordPress iOS [version]

Start in AztecPostViewController.swift around the PHPickerViewController reference at line 426 and review closeMediaPickerInputViewController(), including its iPad multitasking resize behavior. Verify the picker remains usable while avoiding the PUPickerRemoteViewController weak-reference crash, then test the behavior on iPad.