wordpress-mobile / wordpress-mobile/WordPress-iOS
Weekly Roundup: Add singular strings to notification
Open
Nobody has claimed this yet.
[Type] Enhancement
Notifications
- Dominant language
- Swift
- Stars
- 3.9k
- Forks
- 1.2k
- Avg merge
- 23h 51m
- Merged PRs (30d)
- 58
Description
Expected behavior
The singular form of the noun is used when the value is 1.
- view
- like
- comment
Actual behavior
The plural form of the noun is used when the value is 1.
- views
- likes
- comments
Observed in issue #19990
Steps to reproduce the behavior
- Trigger a Weekly Roundup notification for a site with 1 view, comment, and or like
Notes
Tested on iPhone 12 Pro, iOS 16.2, WPiOS 21.6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in WordPress/Classes/Utility/BackgroundTasks/WeeklyRoundupBackgroundTask.swift at the linked notification string locations and review WeeklyRoundupBackgroundTaskTests.swift. Reproduce the case with one view, like, and comment, then update the notification wording so singular values use singular nouns and verify the string tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- localization, mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100