wordpress-mobile / wordpress-mobile/WordPress-iOS
Show `check-network` title when switch off network on listView.
Open
Nobody has claimed this yet.
[Type] Enhancement
Network/Sync
- Dominant language
- Swift
- Stars
- 3.9k
- Forks
- 1.2k
- Avg merge
- 23h 51m
- Merged PRs (30d)
- 58
Description
Expected behavior
When NoResultsViewController display the empty-result title on the screen, switch the network to disconnect.
The label will change to check-network title.
Actual behavior
When NoResultsViewController display the empty-result title on the screen, switch the network to disconnect.
The label does not change.
Steps to reproduce the behavior
- Launch the app.
- Log in with an account without any (post/media/pages) content in your site or add a new site for any account.
- Navigate the
My Sitetab. - tap (post/media/pages) on side-menu
- turn off network
| Device | iPhone | iPad |
|---|---|---|
| Actual |  |
 |
| Expect |  |
 |
Tested on [iPhone14, iPad 9], iOS [16], WPiOS [20.8]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating NoResultsViewController and the list-view empty-result state. Reproduce the steps with the network disabled, then trace why the label does not switch to the check-network title and verify that the title changes for empty post, media, and page lists.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100