wordpress-mobile / wordpress-mobile/WordPress-iOS

Streamline and update `Rakefile`

Open
#18,852 9 comments 0 reactions 1 assignee View on GitHub

@mokagio is already working on this.

Since Jun 9, 2022.

[Type] Tech Debt Tooling
Dominant language
Swift
Stars
3.9k
Forks
1.2k
Avg merge
23h 51m
Merged PRs (30d)
58

Description

While working on #18845 and #18850, I noticed a few things that could be improved in the Rakefile:

  • DRY how we load Podfile.lock
  • We have tasks such as test and clean that are redundant given our use of Fastlane. We should either remove them or make them run the appropriate Faslane lane under the hood.

https://github.com/wordpress-mobile/WordPress-iOS/blob/2185a1e1c2cdaa0b089e93ba75b315e058f360ce/Rakefile#L216-L224

  • Same goes for this custom xcodebuild call. Fastlane can do this for us with extra parameter and safety checks.

https://github.com/wordpress-mobile/WordPress-iOS/blob/2185a1e1c2cdaa0b089e93ba75b315e058f360ce/Rakefile#L732-L743

Also note that xcodebuild call will likely fail, because "iPhone 6s" is no longer one of the Simulator that ship with Xcode out of the box:

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.