wordpress-mobile / wordpress-mobile/WordPress-iOS
[Site Design Revamp] Preview View - Fire previewed event when viewed
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 3.9k
- Forks
- 1.2k
- Avg merge
- 23h 51m
- Merged PRs (30d)
- 58
Description
Description
Note: This is not required until implementing the carousel view.
Confirm that the event enhanced_site_creation_site_design_preview_viewed only fires when the user is looking at the view, rather than when it loads. The Site Design Screen Improvements project will potentially load multiple hidden views at once in a scrolling carousel and we want to prevent firing the event if the view isn't actually being displayed.
If it makes more sense to move this responsibility to the carousel view, we can, since it will know the current preview it's showing.
PRs should target the feature/site-design-revamp feature branch.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating where enhanced_site_creation_site_design_preview_viewed is fired in the Site Design preview flow, then read the carousel view planned in issue #18438 and the preview view lifecycle. Confirm the event is tied to the preview currently visible rather than merely loaded, and verify hidden previews do not fire it. Target the feature/site-design-revamp branch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100