wordpress-mobile / wordpress-mobile/WordPress-iOS

P2 Comments: GitHub embed blocks aren't shown

Open
#18,225 7 comments 0 reactions 1 assignee View on GitHub

@dvdchr is already working on this.

Since Mar 29, 2022.

[Pri] Low [Type] Bug Comments
Dominant language
Swift
Stars
3.9k
Forks
1.2k
Avg merge
23h 51m
Merged PRs (30d)
58

Description

Expected behavior

A GitHub embed block is shown inline with the comments.

Actual behavior

A blank space is shown where the GitHub embed block should be.

Steps to reproduce the behavior
  1. Open Reader
  2. Locate a P2 post that contains a comment with embedded GitHub content (e.g. Issue, PR)
  3. Observe that the space is empty
Desktop Mobile
Screen Shot 2022-03-28 at 11 33 36
Other notes

@AliSoftware found that sometimes the sticky header will disappear. See p1648456550376559-slack-C011BKNU1V5.

Tested on iPhone 12 Pro, iOS 15.4, WPiOS 19.5.0.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.