wordpress-mobile / wordpress-mobile/WordPress-iOS

App not always scrolling to correct comment in notifications

Open
#16,897 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Pri] Medium [Type] Bug Comments Linked to App Review Notifications
Dominant language
Swift
Stars
3.9k
Forks
1.2k
Avg merge
23h 51m
Merged PRs (30d)
58

Description

Expected behavior

When tapping a notification about a comment, tapping on the comment should make the app should scroll all the way to the comment, even if it is in a long thread of comments.

Actual behavior

When tapping a notification, the app doesn’t always scroll all the way to the comment if it’s a long way down (e.g. near the end of a comment thread or project thread). I have seen it fail to scroll all the way, sometimes stopping midway down the thread. Other times it does scroll to the correct comment.

This scrolling issue was a known bug but was addressed in https://github.com/wordpress-mobile/WordPress-iOS/pull/16802 which has the 17.8 milestone. So I’m bringing it up here in case there’s a lingering bug.

Steps to reproduce the behavior
  1. Locate a notification about a comment (e.g. another user liked your comment)
  2. Tap the notification in the app's Notifications tab and be taken to the "Likes" screen
  3. Tap the comment itself and be taken to the "Comments" screen
  4. Notice that the app doesn't scroll you down to the comment in question, sometimes it scrolls half-way, for example

I was able to reproduce this 2 out of 2 times; however, when I went back to try it again and could only reproduce 1 out of 5 times.

Tested on iPhone 11, iOS 14.5, WPiOS 17.8 beta

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the notification-to-Likes-to-Comments flow described in the reproduction steps and the earlier fix in PR 16802. Reproduce the intermittent scrolling failure with long comment or project threads on the stated iPhone/iOS setup. Done means tapping a notification consistently scrolls to the referenced comment, including comments near the end of a long thread.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.