wordpress-mobile / wordpress-mobile/WordPress-iOS

Domain credit prompt showing for site that already has a mapped domain

Open
#12,579 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Discussion Domains
Dominant language
Swift
Stars
3.9k
Forks
1.2k
Avg merge
23h 51m
Merged PRs (30d)
58

Description

Expected behavior

If a site already has a mapped custom domain, I don't expect to see the domain credit prompt on the site detail screen.

Actual behavior

The domain credit prompt shows up, even if the site has a mapped domain.

IMG_C3CBEC7F8469-1

Steps to reproduce the behavior

The prompt also shows up for sites that use .blog subdomains. Create a site with a .blog subdomain and add a plan to it. You should see the domain credit prompt.

We could potentially hide the prompt using DomainsService's refreshDomainsForSite method, as this tells us what sort of domains a site has.

However, Calypso also appears to have the same behaviour. And I can see that it's a valid case for a user with a .blog subdomain (or even an older custom mapped domain) that they might want to register a new domain.

Perhaps instead, a better solution would be to provide a way to dismiss the domain credit prompt if you're not interested (although would we need somewhere for the user to find it later?).

Tested on iPhone 11 Pro, iOS 13.1, WPiOS 13.3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the site detail screen's domain credit prompt and the DomainsService refreshDomainsForSite path, then compare behavior for mapped domains and .blog subdomains. The issue does not settle whether to hide the prompt or add dismissal, so confirm that requirement first; done means the chosen behavior is covered for the reported cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.