wordpress-mobile / wordpress-mobile/WordPress-iOS
Plugins: Remove option shows for unremovable plugins
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 3.9k
- Forks
- 1.2k
- Avg merge
- 23h 51m
- Merged PRs (30d)
- 58
Description
Expected behavior
To show the removal option only for plugins that can be removed from a site.
Actual behavior
When you access an Atomic site that has plugins that can't be removed, the app lets you click on the Remove link, but it shows an error when you try to remove it.
Steps to reproduce the behavior
Add an Atomic site on the app and check plugins such as Jetpack, AMP, Gutenberg, etc.
Tested on iPhone Xs, iOS 12.3.1, WPiOS 12.8.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue on an Atomic site with Jetpack, AMP, or Gutenberg installed, then trace the plugin list and its Remove action in the iOS app. Done means the removal option is not shown for plugins that cannot be removed, and attempting removal no longer produces this error path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100