wordpress-mobile / wordpress-mobile/WordPress-iOS

Plugins: Improve plugin install error message for non-site-owner admins

Open
#10,537 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement Jetpack Plugins
Dominant language
Swift
Stars
3.9k
Forks
1.2k
Avg merge
23h 51m
Merged PRs (30d)
58

Description

Expected behavior

As an admin who isn't the site owner on a WordPress.com Business site, I shouldn't be able to install the first plugin on the site. From the Adding plugins support doc:

Note: For a site with Business plan and multiple administrators on them, only the account that owns the site, purchases Business plan on it, and registers or maps a domain name to it, is able to install the first plugin or third-party theme. After the first plugin is installed, other administrators on the site will be able to install plugins on it as well.

When I try to install a plugin, I expect a clear message explaining that. Here's what Calypso shows when another admin tries to install a plugin:

screenshot 2018-11-23 10 58 02

Actual behavior

In the app, the error message is generic and confusing when I'm an admin on the site:

Plugin feature requires admin privileges.

2018-11-23 10 54 44

Steps to reproduce the behavior
  1. Create a WordPress.com site with the Business plan.
  2. Invite another user to be an admin on the site.
  3. Log in to the app as the second admin.
  4. Go to My Sites > Plugins.
  5. Select a plugin and try to install it.
Tested on iPhone XS, iOS 12.1, WPiOS 11.3.0.20181119

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from My Sites > Plugins using a non-owner administrator on a WordPress.com Business site, then trace the app's generic "Plugin feature requires admin privileges" error. Update the install failure wording to explain the site-owner restriction for the first plugin, and verify the message during the reported installation flow.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.