wordpress-mobile / wordpress-mobile/WordPress-Android
Standardize delay of search requests through the app
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
It looks like there are various search query delay values throughout the app (e.g. Pages View Model, Site Creation Domains View Model, Site Creation Verticals View Model, Site Creation Domain Adapter, Username Changer Full Screen Dialog). Should we consolidate those into a single constant for a consistent experience when searching? If the delay should be different based on the API call or what is being searched, should we at least consolidate the domain searching delays (e.g. Site Creation Domains View Model, Site Creation Domain Adapter, and this one)?
Originally posted by @theck13 in https://github.com/wordpress-mobile/WordPress-Android/pull/9715
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the delay values and search behavior in PagesViewModel.kt, NewSiteCreationDomainsViewModel.kt, NewSiteCreationVerticalsViewModel.kt, SiteCreationDomainAdapter.java, and UsernameChangerFullScreenDialogFragment.java. First determine whether one delay is appropriate or domain searches need their own value; the work is done when the agreed strategy is consistently applied across the relevant search requests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, kotlin
- Domain
- mobile
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100