wordpress-mobile / wordpress-mobile/WordPress-Android
Address `UnsafeImplicitIntentLaunch` lint error
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
Expected behavior
UnsafeImplicitIntentLaunch lint error is not raised when running lint task.
Actual behavior
UnsafeImplicitIntentLaunch is reported 12 times.
Steps to reproduce the behavior
Remove UnsafeImplicitIntentLaunch from the lint baseline file and run lint task (after #21082 is merged).
From what I understood in my research, some Intent calls made for a system web browser are considered by lint to launch JetpackConnectionResultActivity, which only cares about wordpress://jetpack-connection?reason={error} type of links (not https). I'd appreciate a second check if this make sense. I'm also not sure what's the prefered solution - suppressing, or maybe there's something better like communicating to Intents that it should point to external components only?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Remove UnsafeImplicitIntentLaunch from the lint baseline as described and run the lint task after #21082 is merged. Inspect the 12 reported Intent calls involving JetpackConnectionResultActivity, then confirm that the chosen fix leaves the lint task without these reports.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile, security, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100