wordpress-mobile / wordpress-mobile/WordPress-Android
Additional UI tests related to image optimization settings
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
When a user uploads media for the first time and hasn't already configured the optimization settings under App Settings, we display a popup. The popup informs them that image optimization is enabled by default, and allows them to turn that setting off if they'd like to.
| Optimization popup | Default App Settings |
|---|---|
Whether or not the popup displays is determined by the shouldAdvertiseImageOptimization() function.
We already have OptimizeMediaUseCaseTest.kt, which is used in AddLocalMediaToPostUseCaseTest.kt to check images are optimised depending on if the setting’s on or off, amongst other relevant workflows. It would be nice to add some additional tests to ensure the setting is on by default for fresh installs, as well as to check that the popup displays in the specific scenarios it's mean to.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with shouldAdvertiseImageOptimization() in WordPress/src/main/java/org/wordpress/android/util/WPMediaUtils.java, then review OptimizeMediaUseCaseTest.kt and AddLocalMediaToPostUseCaseTest.kt. Add coverage for the default setting on fresh installs and the specified popup scenarios; done means those workflows are verified by the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, java, kotlin
- Domain
- mobile, testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100