wordpress-mobile / wordpress-mobile/WordPress-Android

Confetti effect is not working

Open
#18,435 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Pri] Low [Type] Bug Notifications
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Expected behavior

When the milestone notification detail screen is opened, a confetti effect should be displayed. You can see the expected confetti effect in its introducing PR.

Actual behavior

When the milestone notification detail screen is opened, the confetti effect is not displayed.

device-2023-05-15-235235.webm

Steps to reproduce the behavior
  1. Open the JP app.
  2. Log in to a site that has at least 50 views.
  3. Navigate to Notifications.
  4. Locate the milestone notification that says Congratulations! Your site, New Site Title passed 50 all-time views. and tap on it.
  5. Notice that the confetti effect is not present.
Tested on Pixel 4 emulator, Android 13, JPAndroid 22.3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the introducing PR 14151 and the milestone notification detail screen flow. Reproduce the issue using the listed steps on an Android 13 emulator, then verify that opening the 50-view milestone notification displays the confetti effect.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.