wordpress-mobile / wordpress-mobile/WordPress-Android

Dark Mode: 'Push notifications are turned off' text is unreadable due to low contrast

Open
#18,312 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement Notifications UI
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Expected behavior

I would expect all informational banners within the app to remain readable when dark mode is enabled.

Actual behavior

If push notifications are turned off, a banner related to this is displayed to users on the notifications screen. The text in this banner is unreadable when dark mode is enabled due to low contrast. The text is changed to white, but the banner's background colour remains a light shade.

Light Mode Dark Mode
Steps to reproduce the behavior
  • Ensure notification are turned off for the Jetpack app. This can be done via the Apps section in your phone's Settings app.
  • Enable dark mode on within the Jetpack by navigating to App SettingsAppearance.
  • Navigate to the Notification screen and observe the 'Push notifications are turned off' banner at the top.
Tested on Pixel 6, Android 13, JPAndroid 22.2-rc-2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on the Notifications screen after disabling notifications and enabling dark mode through App Settings → Appearance. Inspect the implementation of the “Push notifications are turned off” banner and its dark-mode styling; done means the banner text remains readable with sufficient contrast in dark mode without regressing light mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.