wordpress-mobile / wordpress-mobile/WordPress-Android

Login: Pre-select site on confirmation screen when logging into WPcom account via site address.

Open
#17,843 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement Login
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Expected behavior

I expected the app to 'remember' what site address I entered at the beginning of login, and bring me to that site once I complete the login process.

Actual behavior

When using “existing site address login” flow, and entering a correct WPCOM site address, and then entering correct WPCOM account credentials, the site picker is still shown at the end, making the site address entered at the flow beginning feel irrelevant.

Suggested solution

When arriving at the confirmation screen, pre-select the site the user logged in with. The site should be highlighted on the site-picker, and perhaps brought to the top of the list.

Steps to reproduce the behavior
  1. Log out of the app.
  2. Tap "Enter your existing site address" on the start screen.
  3. Enter a site address that is associated with your WordPress.com account but isn't your primary site.
  4. Note you are prompted to login with WordPress.com; enter your credentials to continue.
  5. Note the confirmation screen lists all your sites, and asks you to choose a site to open.
  6. Scroll through the list to find the site you logged in with.
Tested on Samsung Galaxy S21, Android 12, WPAndroid 21.6-rc-1

Reported in beta testing: p5T066-3NG-p2#comment-14214

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the existing-site-address login flow and the confirmation screen's site picker in the WordPress Android app. Reproduce the steps with a non-primary site, then identify where the entered site is lost or ignored. Done means that site is highlighted, and preferably moved to the top, when the confirmation screen appears.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
authentication, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.