wordpress-mobile / wordpress-mobile/WordPress-Android

[Screenshots] Mocked notifications are always in English

Open
#17,132 2 comments 2 reactions 1 assignee View on GitHub

@AjeshRPai is already working on this.

Since Sep 21, 2022.

[Pri] Medium [Type] Bug Tooling UI Tests
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Parent: #17128

When running the WPScreenshotTest and JPScreenshotTest to capture Play Store screenshots, we mock the network requests, including the ones returning notifications to be shown in the Notifications tab.

Those mocks always return English copies though, which means that this screen shows notifications in English ("X and 5 others liked your post")… even when capturing screenshots for non-en-US locale.

This makes those screenshots inconsistent with the reality, and could make users think, looking at the Play Store screenshots, that the Notifications screen is not localized (while in the real, non-mocked world, they are).

5-reply-in-real-time

Warning: Those tests were run from the branch from this PR (which fixes screenshot automation). If you start working on this, make sure that either that PR has landed since, or that you cut your branch to fix this from this PR's branch, to benefit from the tooling fixes related to screenshots that I've made so far.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.