wordpress-mobile / wordpress-mobile/WordPress-Android

Sign in with SMS in 2FA 1password blocks the line (text in a code instead)

Open
#15,972 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement Login
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Expected behavior
  • 1password should not block the view of the line of text.
  • The dialogue should only show if there are numerous attempts only.
Actual behavior
  • I signed in with a non-a8c Gmail. Before I could read clearly what the line is (text me a code instead), 1password appeared soon and blocked the view of the text underneath.
  • I tapped the back arrow, one message dialogue popped up saying "…too many attempts to send an SMS…", even though I just requested once.
Steps to reproduce the behavior
  • Signed in with Gmail and choose SMS in 2FA
  • 1password showed up
  • Tap the arrow showed the dialog saying "…too many attempts to send an SMS…."

screenshot_20220209-133450
screenshot_20220209-133121

Tested on [device], Android [version], WPAndroid [version]

Pixel 5, Android version 12, v19.2-rc-3(1171)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the SMS 2FA sign-in flow on a Pixel 5 running Android 12 with v19.2-rc-3 (1171), using the supplied screenshots as reference. Trace the view and dialog shown when 1Password appears and the back arrow is tapped; done means the “text me a code instead” line remains readable and the attempt-limit dialog appears only after numerous attempts.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
authentication, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.