wordpress-mobile / wordpress-mobile/WordPress-Android

Follow conversation by push notifications case to monitor/improvement

Open
#15,471 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Task Comments
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

This is related to an observed behaviour while testing this PR here

Slack internal ref: p1633941032482100-slack-C01CW1VMLAF

If the site that you want to follow a conversation on, has this below site global setting in the reader active

then the /sites/$site_id/posts/$post_id/subscribers/mine/update endpoint cannot set to true the receive_notifications field; thus in this condition currently an error is got back and the push notifications cannot be enabled.

This would require some changes in the endpoint but numbers for this scenario looking at the calypso_reader_comment_emails_toggle_on seems pretty low (if we are not wrong, like only 0.078% of MAUs are using that feature). We have setup a change in the endpoint (diff D68317) to bump a counter that we can review to define eventual action on the endpoint.

Props to @aerych for the time and advices looking into this 🙇 !

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced PR and the /sites/$site_id/posts/$post_id/subscribers/mine/update endpoint behavior; the issue does not name a repository file or test. Confirm the receive_notifications=true failure under the reader setting, then verify that the monitoring counter captures this case so a decision on the endpoint can be made.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
api, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.