wordpress-mobile / wordpress-mobile/WordPress-Android
Theme images not loading after screen rotation
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
Expected behavior
The images should be displayed after being downloaded
Actual behavior
The images won’t be displayed until you either
- scroll up/down so they get out and back to the screen or
- rotate the phone back to its original orientation.
Steps to reproduce the behavior
- Go to themes
- Scroll down until you see themes with not downloaded images
- Rotate the phone before the images get fully loaded
- Notice that the images are not displayed
https://user-images.githubusercontent.com/304044/129712113-0b98901a-9bb7-483a-b084-aa7d9ef6261d.mp4
Additional context
The bug was revealed after https://github.com/wordpress-mobile/WordPress-Android/pull/15060 since it forced downloading new images skipping the cache.
Internal ref p5T066-2yC-p2#comment-9608
Tested on Pixel 2 XL, Android 11, WPAndroid 17.9
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in the Themes screen using the listed steps on Android 11, then inspect the image-loading and screen-rotation lifecycle around the change in pull request #15060. Confirm that images downloaded during rotation are displayed without scrolling or rotating back, and verify the behavior on the described device or emulator.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100