wordpress-mobile / wordpress-mobile/WordPress-Android

Login: warn that SMS will not be sent when logging into internal account

Open
#14,984 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement Login
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Expected behavior

When logging in to a WordPress.com account and tapping "Text me a code instead", I expected a code to be sent.

Actual behavior

A brief message says the SMS code has been requested, however it is never sent.

Steps to reproduce the behavior

To reproduce:

  1. Begin to login to a WordPress.com account.
  2. Enter email address and proceed to enter password.
  3. At the point when you'd normally enter your auth code, tap "Text me a code instead".
  4. Note the "requesting a verification code via SMS"
  5. Wait a while and notice the SMS never arrives.

https://user-images.githubusercontent.com/15107387/124462302-41964000-dd9a-11eb-8928-9ea891fad177.mp4

If you follow the same steps from WordPress.com in a web browser, the SMS is sent and arrives.

Tested on Samsung Galaxy S21, Android 11, WPAndroid 17.7-rc-2

Reported in beta testing: p5T066-2rt#comment-8988

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the WordPress for Android login flow at the verification-code step and reproduce the SMS request described in the issue. Compare the internal-account behavior with the WordPress.com browser behavior, then verify that users are warned that SMS will not be sent for the affected account type.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
authentication, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.