wordpress-mobile / wordpress-mobile/WordPress-Android
To-Do Block: check/uncheck tasks from Reader doesn't work
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
iOS issue: https://github.com/wordpress-mobile/WordPress-iOS/issues/16792
Expected behavior
When I tap on a task, the task is marked as done (strikethrough) and my @ is added after it between parenthesis. Just like it is on the web.
Actual behavior
Tapping on the task does nothing.
Steps to reproduce the behavior
- Create a post in an internal P2 and add a To-Do list block
- Add a few tasks
- Open this post on Reader
- Tap on any of the tasks
- Nothing happens
Technical details
In order for this to work on mobile Reader, we would need:
- When a task is tapped, the native application needs to trigger a request
- We need to manipulate the HTML to mark the task as "done"
The big issue I see here is the request. By doing a quick investigation (you can just use your browser to do the same) it seems to me that what happens when a task is marked as done is that a request to update the content of this post is triggered. This is tricky to do from the Reader because sometimes what we have is just the HTML output (even with some stuff cleaned). If we use that to update the post, we might end up breaking it (and removing the block declarations).
Ps.: it worths noting that this issue doesn't affect end users, given to-do block is used on internal P2s.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Reader behavior described in the issue with a post containing a To-Do list block, then compare it with the linked iOS issue and the web behavior. Trace how Reader obtains and updates post HTML, especially the request needed when a task is tapped. Done means tasks can be marked complete in Reader without removing block declarations or otherwise breaking the post.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100