wordpress-mobile / wordpress-mobile/WordPress-Android
Login: Navigating back from the 2FA screen after selecting an account via Smart Lock loops back to the 2FA screen
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
Expected behavior
After selecting a WordPress account with 2FA enabled from the Smart Lock dialog on the Prologue, the user is redirected to the 2FA screen. Navigating back from that screen should redirect the user to either the Email/Password screen or the Prologue screen.
Actual behavior
The user gets stuck in a loop:
https://user-images.githubusercontent.com/830056/123467941-7f8bab00-d5c7-11eb-80dc-af6a0453bbd1.mp4
Steps to reproduce the behavior
- Make sure you have a WordPress account with 2FA enabled saved on SmartLock.
- On the Prologue screen, notice the SmartLock dialog.
- Select the WordPress account that has 2FA enabled.
- Notice a progress dialog on top of the Email/Password screen.
- Notice you're redirected to the 2FA screen.
- Press back.
- Notice the progress dialog on top of the Email/Password screen briefly appears again.
- Notice you're back on the 2FA screen.
Tested on Motorola One, Android 10, WPAndroid 17.6-rc-4
Thanks to @AliSoftware for the original report 🙇♂️
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Smart Lock flow from the Prologue with an account that has 2FA enabled, then follow the Email/Password and 2FA screens while pressing back. Compare the observed navigation with the expected return to the Email/Password or Prologue screen. Done means pressing back from 2FA no longer loops back to 2FA.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100