wordpress-mobile / wordpress-mobile/WordPress-Android

Reader site filters: remove filter tab bar for P2s and A8C

Open
#14,246 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement P2 Reader
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

In the reader we already added the possibility to filter by site in Following and later in P2s and Automattic tabs.

The bottom sheet that the filter opens has tabs itself that makes sense in the Following page (since it has 2 inner tabs) but not much in the P2s and Automattic pages (since we have only one inner tab there

Following P2s
image image

We should remove the filter inner tabs in case we have 1 tab page only (P2S and A8C)

Linking the original issue from iOS wordpress-mobile/WordPress-iOS#15496

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Reader site-filter bottom sheet and compare its behavior on Following, P2s, and Automattic pages. The change is complete when the inner filter tabs remain for Following but are absent for the single-tab P2s and Automattic pages.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.