wordpress-mobile / wordpress-mobile/WordPress-Android

Site Address accepts emails when trying to log in using an URL

Open
#14,041 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement Login
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

I've seen a few cases when users are getting an incorrect username/password message but they are sure that the credentials are correct. What is probably happening (example on 3729175-zen) is that users type their own email instead of their site URL. And for some reason, we accept that if the part after the @ is a WP site.

Expected behavior

To see an error message explaining to the user that this field is for site URLs, not emails.

Actual behavior
  1. If you type an email (valid or not) followed by a domain that is not pointing to a WP site, you'll see the 'The site at this address is not a WordPress site` message.
  2. If you type an email (valid or not) followed by a domain that IS pointing to a WP site, we will let the user proceed and ask them to log in (to an email).

Image from https://github.com/wordpress-mobile/WordPress-iOS/issues/15868 :

Captura de Tela 2021-02-11 às 18 39 31
Steps to reproduce the behavior
  1. Open the app while unlogged
  2. Click on Enter your existing site address
  3. Type something like http://lekrkr@example.com. Make sure that example.com is a WP site.
Tested on iPhone 7, iOS 14.4, WPiOS 16.5 and 16.6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from the “Enter your existing site address” flow using an email-like address whose domain is a WordPress site, then trace the site-address validation and login entry point. Done means email-like input shows an error explaining that the field accepts site URLs, while valid site URLs still proceed normally.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
authentication, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.