wordpress-mobile / wordpress-mobile/WordPress-Android
Site Address accepts emails when trying to log in using an URL
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
I've seen a few cases when users are getting an incorrect username/password message but they are sure that the credentials are correct. What is probably happening (example on 3729175-zen) is that users type their own email instead of their site URL. And for some reason, we accept that if the part after the @ is a WP site.
Expected behavior
To see an error message explaining to the user that this field is for site URLs, not emails.
Actual behavior
- If you type an email (valid or not) followed by a domain that is not pointing to a WP site, you'll see the 'The site at this address is not a WordPress site` message.
- If you type an email (valid or not) followed by a domain that IS pointing to a WP site, we will let the user proceed and ask them to log in (to an email).
Image from https://github.com/wordpress-mobile/WordPress-iOS/issues/15868 :
Steps to reproduce the behavior
- Open the app while unlogged
- Click on Enter your existing site address
- Type something like
http://lekrkr@example.com. Make sure thatexample.comis a WP site.
Tested on iPhone 7, iOS 14.4, WPiOS 16.5 and 16.6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue from the “Enter your existing site address” flow using an email-like address whose domain is a WordPress site, then trace the site-address validation and login entry point. Done means email-like input shows an error explaining that the field accepts site URLs, while valid site URLs still proceed normally.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- authentication, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100