wordpress-mobile / wordpress-mobile/WordPress-Android
Activity Log Footer shown even on sites with Backup support
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
Expected behavior
"Since you are on a free plan, you'll see limited events in your activity" footer is displayed only for users who are on a free plan and haven't purchased Backup product.
Actual behavior
The footer is displayed for all users with a free plan no matter if they have purchased the backup product.
Note
The check if the user has purchased backup plan is used here - it's asynchronous and not cached. We plan to fetch jetpack capabilities on My Site screen and cache the result - we might want to delay this ticket and use the cached value so we don't need to deal with asynchronicity when building the list of events. This is now ready to be worked on.
Steps to reproduce the behavior
- Select a site on a free plan on which the backup product has been purchased
- Open Activity Log
- Scroll to the bottom
- Notice the footer is shown
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in WordPress/src/main/java/org/wordpress/android/viewmodel/activitylog/ActivityLogViewModel.kt around the referenced backup-plan check, then trace how the Activity Log footer is shown. Verify the footer is limited to free-plan users without the purchased Backup product by following the reproduction steps.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100