wordpress-mobile / wordpress-mobile/WordPress-Android
Whitelisted IP addresses pref doesn't work in Jetpack settings
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
Expected behavior
When I click on "Whitelisted IP addresses" in Jetpack Security settings I expect "Whitelisted IP Addresses" screen to show up.
Actual behavior
When I click on "Whitelisted IP addresses" in Jetpack Security settings nothing happens.
Note 1: The theme issue is fixed in this PR.
Note 2: This issue is blocking https://github.com/wordpress-mobile/WordPress-Android/pull/13402 and https://github.com/wordpress-mobile/WordPress-Android/pull/13408
Note 3: It seems the logic was actually never even implemented. It works fine when the Jetpack Security settings are accessed from My Site -> Settings -> Security -> Whitelisted IP Addresses.
Steps to reproduce the behavior
Prerequisites - jetpack site
- Create a post on the web with a blog which is not supported on mobile
- Open My Site -> Settings -> (Jetpack) Security -> disable "Allow WordPress.com login"
- Go to My Site -> Blog Posts -> open the post from step 1
- Click on the question mark on the unsupported block
- Click on "Open Jetpack Security Settings"
- Click on "Whitelisted IP Addresses"
- Notice nothing happens
Update 11/24
When https://github.com/wordpress-mobile/WordPress-Android/pull/13402 is merged this issue won't be reproducible anymore. The row was removed in this PR. Goal of this task is to re-add that option. (it's still available when the settings are accessed from My Site-> Site Settings -> Security)
Prerequisites - jetpack site
- My Site
- Click on "Jetpack settings" option
- Notice the "whitelisted IP addresses" option is not shown
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the "Open Jetpack Security Settings" flow and compare it with the working My Site → Site Settings → Security path. The task is done when the Whitelisted IP Addresses option is present in Jetpack settings and opens the existing screen; verify the listed reproduction steps on a Jetpack site.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100