wordpress-mobile / wordpress-mobile/WordPress-Android

Comments: once a comment has been trashed and restored it no longer appears in the trash if I trash it again (Jetpack only)

Open
#12,881 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Pri] Low [Type] Bug Comments Jetpack
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Steps to reproduce, sourced from https://github.com/wordpress-mobile/WordPress-Android/issues/7131:

  1. Create reply to a default comment that comes with my WP install.
  2. Trash the comment we created.
  3. Changed my mind. Let’s restore it.
  4. But no. Let’s trash it after all.
  5. Ok. Let’s see all the comments we got.

Result: the reply to the default comment that I trashed, restored, then trashed again appears approved in the app even though it should be trashed. (4m35s)

Result, 2nd test: I also tried this test with a comment on a new post and found the same result—once I have trashed and restored a comment then when I trash it in the app it does get trashed but continues to appear as approved in the app. (4m4s)

WP Admin trashed-restored-trashed post appears normally Calypso trashed-restored-trashed post appears normally WPAndroid trashed-restored-trashed post appears approved 😕
Screen Shot 2020-09-03 at Sep 3 10 43 24 AM Screen Shot 2020-09-03 at Sep 3 10 43 03 AM Screen Shot 2020-09-03 at Sep 3 10 42 42 AM

Tested with WPAndroid 15.6-rc-2 on Pixel 3 Android 10 using `likely-herring.jurassic.ninja` running WordPress 5.5.1. and Jetpack 8.9.

App logs for the timestamp matching the 2nd video 
WordPress - 15.6-rc-2 - Version code: 913
Android device name: Google Pixel 3

01 - [Sep-03 17:15 API] Dispatching action: CommentAction-PUSHED_COMMENT
02 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCH_COMMENTS
03 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCHED_COMMENTS
04 - [Sep-03 17:15 COMMENTS] NEW STATUS : All
05 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCH_COMMENTS
06 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCHED_COMMENTS
07 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCH_COMMENTS
08 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCHED_COMMENTS
09 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCH_COMMENTS
10 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCHED_COMMENTS
11 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCH_COMMENTS
12 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCHED_COMMENTS
13 - [Sep-03 17:15 COMMENTS] Creating CommentsDetailActivity
14 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCH_COMMENTS
15 - [Sep-03 17:15 UTILS] trackLastActivity, activityId: Comment Detail
16 - [Sep-03 17:15 UTILS] trackLastActivity, activityId: Comment Detail
17 - [Sep-03 17:15 SUGGESTION] service created
18 - [Sep-03 17:15 SUGGESTION] Skipping suggestion update for site 182394729 because the suggestions were recently updated.
19 - [Sep-03 17:15 SUGGESTION] Skipping tags update for site 182394729 because the tags were recently updated.
20 - [Sep-03 17:15 SUGGESTION] Skipping suggestion update for site 182394729 because the suggestions were recently updated.
21 - [Sep-03 17:15 SUGGESTION] Skipping tags update for site 182394729 because the tags were recently updated.
22 - [Sep-03 17:15 API] Dispatching action: CommentAction-FETCHED_COMMENTS
23 - [Sep-03 17:15 UTILS] trackLastActivity, activityId: Comments
24 - [Sep-03 17:15 SUGGESTION] service destroyed
25 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
26 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
27 - [Sep-03 17:16 API] Dispatching action: CommentAction-PUSH_COMMENT
28 - [Sep-03 17:16 API] Dispatching action: CommentAction-PUSHED_COMMENT
29 - [Sep-03 17:16 COMMENTS] NEW STATUS : Trashed
30 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
31 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
32 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
33 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
34 - [Sep-03 17:16 COMMENTS] NEW STATUS : All
35 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
36 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
37 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
38 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
39 - [Sep-03 17:16 COMMENTS] Creating CommentsDetailActivity
40 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
41 - [Sep-03 17:16 UTILS] trackLastActivity, activityId: Comment Detail
42 - [Sep-03 17:16 UTILS] trackLastActivity, activityId: Comment Detail
43 - [Sep-03 17:16 SUGGESTION] service created
44 - [Sep-03 17:16 SUGGESTION] suggestion service > updating suggestions for siteId: 182394729
45 - [Sep-03 17:16 SUGGESTION] suggestion service > updating tags for siteId: 182394729
46 - [Sep-03 17:16 SUGGESTION] Skipping suggestion update for site 182394729 because a suggestions request is already in progress.
47 - [Sep-03 17:16 SUGGESTION] Skipping tags update for site 182394729 because a tags request is already in progress.
48 - [Sep-03 17:16 SUGGESTION] stopping suggestion service
49 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
50 - [Sep-03 17:16 SUGGESTION] stopping suggestion service
51 - [Sep-03 17:16 UTILS] trackLastActivity, activityId: Comments
52 - [Sep-03 17:16 SUGGESTION] service destroyed
53 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
54 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
55 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
56 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
57 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
58 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
59 - [Sep-03 17:16 COMMENTS] NEW STATUS : Trashed
60 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
61 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
62 - [Sep-03 17:16 API] Dispatching action: CommentAction-PUSH_COMMENT
63 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
64 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
65 - [Sep-03 17:16 API] Dispatching action: CommentAction-PUSHED_COMMENT
66 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
67 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
68 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
69 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
70 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
71 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
72 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
73 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
74 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
75 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
76 - [Sep-03 17:16 COMMENTS] NEW STATUS : All
77 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
78 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
79 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
80 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
81 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCH_COMMENTS
82 - [Sep-03 17:16 API] Dispatching action: CommentAction-FETCHED_COMMENTS
83 - [Sep-03 17:17 UTILS] trackLastActivity, activityId: Comments
84 - [Sep-03 17:17 UTILS] trackLastActivity, activityId: My Site
85 - [Sep-03 17:17 API] Dispatching action: AccountAction-FETCH_ACCOUNT
86 - [Sep-03 17:17 API] WhatsNewStore: fetchWhatsNew
87 - [Sep-03 17:17 API] Dispatching action: AccountAction-FETCHED_ACCOUNT
88 - [Sep-03 17:17 STATS] 🔵 Tracked: site_menu_opened, Properties: {"blog_id":182394729,"is_jetpack":true,"menu_item":"comments"}
89 - [Sep-03 17:17 API] Dispatching action: CommentAction-FETCH_COMMENTS
90 - [Sep-03 17:17 UTILS] trackLastActivity, activityId: Comments
91 - [Sep-03 17:17 COMMENTS] load comments task already active
92 - [Sep-03 17:17 API] Dispatching action: CommentAction-FETCHED_COMMENTS
93 - [Sep-03 17:17 UTILS] trackLastActivity, activityId: My Site
94 - [Sep-03 17:17 API] Dispatching action: AccountAction-FETCH_ACCOUNT
95 - [Sep-03 17:17 API] WhatsNewStore: fetchWhatsNew
96 - [Sep-03 17:17 API] Dispatching action: AccountAction-FETCHED_ACCOUNT
97 - [Sep-03 17:17 STATS] 🔵 Tracked: me_tab_accessed
98 - [Sep-03 17:17 STATS] 🔵 Tracked: support_opened, Properties: {"origin":"ME_SCREEN_HELP"}
99 - [Sep-03 17:17 UTILS] trackLastActivity, activityId: Help Screen

/hat tip @khaykov for the testing steps.

Note: please follow-up with a comment on p4a5px-1Nh-p2 and https://github.com/Automattic/jpop-issues/issues/633 and https://github.com/wordpress-mobile/WordPress-Android/issues/7131 once this issue has been fixed and shipped. cc @lezama @khaykov

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Android comments flow around the CommentAction status changes shown in the logs, focusing on the Jetpack path and the Trashed and All filters. Reproduce the trash, restore, and trash sequence, then verify that the comment is listed as trashed rather than approved after the second trash action.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.