wordpress-mobile / wordpress-mobile/WordPress-Android

[Dark mode] Empty screen on post preview is missing the dark background

Open
#12,076 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Pri] Medium [Type] Bug UI
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Expected behavior

Background should be dark.

Actual behavior

Background should is white, text is the same color (and thus, unredable).

Screenshot_1591102294
Screenshot_1591102940

Note: there are multiple empty pages, I haven't checked if they used the same layout/styles.

Steps to reproduce the behavior

Test 1:

  • Set the app or device in dark mode.
  • Set airplane mode on (to get the "no network" empty view).
  • Open a post in the editor.
  • Tap the "Preview" button.
  • Notice the background color is white, the text is not visible ("No Network" empty view).

Test 2:

  • Set the app or device in dark mode.
  • Switch to a Jetpack site (preview unavailable for locally modified posts).
  • Open an existing post in the editor, edit the post, don't update it.
  • Tap the "Preview" button.
  • Notice the background color is white, the text is not visible ("Preview unavailable" empty view).
Tested on [device], Android [version], WPAndroid [version]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the post preview's "No Network" and "Preview unavailable" empty views with Android dark mode and the reported offline or Jetpack-site conditions. Locate the shared preview empty-view layout or styles, then verify that both views have a dark background and readable text in dark mode.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.