wordpress-mobile / wordpress-mobile/WordPress-Android

Replace Stetho with Flipper

Open
#11,615 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement Tech Debt
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

Stetho is not deprecated yet, but could be soon: https://github.com/facebook/flipper/blob/master/docs/stetho.md

Flipper offers better debugging tools and integration seems as easy as Stetho. There is a random crash happening regularly when Stetho is attached to Chrome which is very annoying when you test the app.

Note: we should do this in FluxC as well.

  java.lang.NullPointerException: Attempt to read from field 'java.lang.Object com.facebook.stetho.inspector.elements.ElementInfo.parentElement' on a null object reference
      at com.facebook.stetho.inspector.elements.ShadowDocument$Update.removeGarbageSubTree(ShadowDocument.java:378)
      at com.facebook.stetho.inspector.elements.ShadowDocument$Update.removeGarbageSubTree(ShadowDocument.java:386)
      at com.facebook.stetho.inspector.elements.ShadowDocument$Update.removeGarbageSubTree(ShadowDocument.java:386)
      at com.facebook.stetho.inspector.elements.ShadowDocument$Update.removeGarbageSubTree(ShadowDocument.java:386)
      at com.facebook.stetho.inspector.elements.ShadowDocument$Update.removeGarbageSubTree(ShadowDocument.java:386)
      at com.facebook.stetho.inspector.elements.ShadowDocument$Update.removeGarbageSubTree(ShadowDocument.java:386)
      at com.facebook.stetho.inspector.elements.ShadowDocument$Update.commit(ShadowDocument.java:360)
      at com.facebook.stetho.inspector.elements.Document.applyDocumentUpdate(Document.java:494)
      at com.facebook.stetho.inspector.elements.Document.updateTree(Document.java:346)
      at com.facebook.stetho.inspector.elements.Document.access$1200(Document.java:31)
      at com.facebook.stetho.inspector.elements.Document$ProviderListener.onPossiblyChanged(Document.java:720)
      at com.facebook.stetho.inspector.elements.android.AndroidDocumentProvider$1.run(AndroidDocumentProvider.java:71)
      at android.os.Handler.handleCallback(Handler.java:739)

An issue has been open for a long time: https://github.com/facebook/stetho/issues/652

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the referenced Flipper documentation and locating the existing Stetho integration in WordPress for Android and FluxC. Compare the integration requirements for both projects; done means Stetho is replaced in both and the reported crash when debugging through Chrome is no longer observed.

Written by the indexing model from the issue text.

Assessment

Tech stack
android
Domain
mobile, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.