wordpress-mobile / wordpress-mobile/WordPress-Android
Extra WPCom REST requests on self hosted sites
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
I was checking Stetho network requests while testing this https://github.com/wordpress-mobile/WordPress-Android/pull/11522 and I found that we're trying to fetch diffs from wpcom REST API even if a self hosted site (non jetpack) is selected.
It's not a big deal, but we're kind of leaking self hosted usage via this extra call.
Expected behavior
No network call to wpcom REST API when a non-jetpack self hosted site is selected.
Steps to reproduce the behavior
- Select a self hosted site.
- Go to the post list.
- Tap on a published post.
Tested on [device], Android [version], WPAndroid [version]
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by selecting a non-Jetpack self-hosted site, opening the post list, and tapping a published post while inspecting requests with Stetho. Trace the published-post flow that requests diffs from the wpcom REST API; done means no wpcom REST request is made for a non-Jetpack self-hosted site.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- api, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100