wordpress-mobile / wordpress-mobile/WordPress-Android

Issues on android:indeterminateTint

Open
#11,476 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Enhancement General
Dominant language
Kotlin
Stars
3.2k
Forks
1.4k
Avg merge
1d 11h
Merged PRs (30d)
69

Description

image

Tested on [device], Android [version], WPAndroid [version]

API 22 and 23

I have found a potential issue that may cause the color of progress bar inconsistent between Android 5.1 and 6.0.

In stats_style.xml, you define a theme

    <style name="BlueMediumProgressBar" parent="Widget.AppCompat.ProgressBar">
        <item name="android:colorAccent">@color/primary_40</item>
        <item name="android:indeterminateTint">@color/primary_40</item>
    </style>

You have used this theme in progress bar as follows:
<ProgressBar android:id="@+id/jetpack_install_progress" style="@style/BlueMediumProgressBar" android:layout_marginBottom="@dimen/margin_extra_large" android:layout_width="24dp" android:layout_height="24dp" android:visibility="gone" tools:visibility="visible" />

But setting android:indeterminateTint only will not take any effect on API level < 22. A possible fix is to add android:indeterminateTintMode="src_atop" or "src_in".

Thanks for your attention.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the BlueMediumProgressBar style in stats_style.xml and the jetpack_install_progress ProgressBar usage described in the issue. Reproduce the styling on Android API 22 and 23, then verify that the indeterminate progress-bar color is consistent across both versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
android
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.