wordpress-mobile / wordpress-mobile/WordPress-Android
Remove selection indicator from the reader bottom sheet.
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 3.2k
- Forks
- 1.4k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 69
Description
As part of the Information Architecture project we are adding a filter to select different streams of posts in the reader. The filter is implemented with a bottom sheet and the main PR is this one.
While reviewing it, it has been noticed a possible UX issue when re-selecting an already selected filter (see this comment for more context).
Two possible routes highlighted by Chris:
- Treat it as a check box. Show a selected state. Tapping on the selected state unselects it. But in this case, I think the sheet should stay open. Currently the sheet closes on any selection, so its more like a quick switcher between sites.
- Removing the selected indicator could make it feel less like a checkbox/radio button and more like a shortcut.
...
...if I was to make a change I would actually do the second one, and not show a selected indicator
cc @osullivanchris and @malinajirka
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #11193 and the reader bottom-sheet implementation it introduces, then check the linked UX discussion for the intended behavior. Done means the selected filter no longer shows a selection indicator in the bottom sheet while the existing stream-selection flow remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- design, mobile
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100